Fix bullet sync bugs & crash

[FileEX]

Summary

• Fixed crash by huge coords
• Fixed potentially incorrect damage values (float precision)
• Fixed potentially incorrect positions (float precision)
• Fixed bugs related to skipping consecutive packets when standing in the same place

Motivation

#4675

Test plan

Unfortunately, I haven’t tested these changes because I currently don’t have access to a second computer, and I don’t want to set up a VM. It would be great if someone could check this.

Checklist

• Your code should follow the coding guidelines.
• Smaller pull requests are easier to review. If your pull request is beefy, your pull request should be reviewable commit-by-commit.

[ArranTuna]

I tested it with 2 PCs and bullet sync is completely broken, no bullets are being synced.

onPlayerWeaponFire was triggered, onClientPlayerWeaponFire doesn't.

[FileEX]

I tested it with 2 PCs and bullet sync is completely broken, no bullets are being synced.

onPlayerWeaponFire was triggered, onClientPlayerWeaponFire doesn't.

Did you test this after my latest commit (50 mins ago)?

[ArranTuna]

I have re-tested with the newest commit and bullets still do not sync.

[ArranTuna]

Just see the flashing, no bullets. I don't know if related to your PR but I don't see the remote player reloading.

[FileEX]

Reloading the weapon is probably a separate issue. As for bullet sync, I’m not really sure what to say, because for me onClientPlayerWeaponFire and onPlayerWeaponFire are being triggered, and the vector values are correct.

I’m not entirely sure what exactly I’m supposed to see. What does the bullet you’re referring to look like? I thought it was the muzzle flash from the weapon.

[ArranTuna]

onClientPlayerWeaponFire triggers for bullets you fire, it does not trigger for remote players. Remote player bullets are not being synced, just the animation and muzzle flash.

[FileEX]

onClientPlayerWeaponFire triggers for bullets you fire, it does not trigger for remote players. Remote player bullets are not being synced, just the animation and muzzle flash.

Are you sure?
https://streamable.com/emvkpc