Add function setSearchLightColor & getSearchLightColor#4666
Open
FileEX wants to merge 3 commits intomultitheftauto:masterfrom
Open
Add function setSearchLightColor & getSearchLightColor#4666FileEX wants to merge 3 commits intomultitheftauto:masterfrom
FileEX wants to merge 3 commits intomultitheftauto:masterfrom
Conversation
qaisjp
reviewed
Jan 26, 2026
qaisjp
reviewed
Jan 26, 2026
| using CHeli_PreSearchLightCone_t = int(__cdecl*)(); | ||
| using CHeli_PostSearchLightCone_t = int(__cdecl*)(); | ||
|
|
||
| static SColor searchLightColor{}; |
Member
There was a problem hiding this comment.
What's going on with this static?
Member
Author
There was a problem hiding this comment.
The CPointLightSA class is static. The RenderHeliLight method is called by each CClientSearchLight in its Render method, which in turn is called by the point lights manager. For each search light, this variable changes its value precisely within the RenderHeliLight method. A better approach can be considered in the future.
qaisjp
reviewed
Jan 26, 2026
qaisjp
previously requested changes
Jan 26, 2026
Member
qaisjp
left a comment
qaisjp
left a comment
There was a problem hiding this comment.
Left some comments. I'm ok with merging this in 1.7
qaisjp
dismissed
their stale review
Change as a whole seems okay, but I don't have enough understanding with SA internals to review Client/game_sa/CPointLightsSA.cpp. Could someone else (maybe @samr46) review this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two new functions that allow you to manage the color of the search light.
Closes #4500
Motivation
#4500
Test plan
I plan to reverse the entire function and render the full effect from within MTA, which will make it clearer and remove the need for hooks and ASM. For now, I don’t know when I’ll have time for that, and it would be a shame for this seemingly desirable feature to just sit idle waiting for better times. That’s why I’m opening a PR with the current implementation.
Checklist