-
-
Notifications
You must be signed in to change notification settings - Fork 464
New effect function fxAddShadow
#1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
drawOnWater may work if you apply a shader to the water which enables depth buffer usage. technique simple
{
pass P0
{
ZEnable = true;
ZWriteEnable = true;
ZFunc = 4;
DepthBias = 0.000001;
SlopeScaleDepthBias = 2;
}
} |
i fixed conflicts and i'm waiting for marge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work overall, good job. I've left a few comments.
Also some files affect all line endings - please can you fix? If you don't know how, I can try to document instructions when I find the time. Just let me know.
Make an tutorial how to fix line endings and pin up somewhere future |
fixed again, unteaded due #1122 |
#1122 is resolved, please can you test this? and resolve conversations for the bits above that you've done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice PR. here's some changes for you.
Client/game_sa/CFxSA.cpp
Outdated
m_textureMap[eShadowType::PLANE] = new RwTexture(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can crash the program. You don't allocate memory for Rw textures using the new operator. You have to use RwTextureCreate
. I want to know where you are deleting this texture? It looks like this will cause a memory leak.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont know how properly use wrcreatetexture, and current code doesnt crash
What's the current state of this @CrosRoad95 ? |
after some updates, it starts crashing almost all time |
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
The changes seem fine, but you have translation commits in the branch and pull request now. |
updated |
The changes for the translation files are still there. |
fixed |
syntax:
Must be used in render function like other dx functions, works better in PreRender ( avoid 1 frame lag )
returns nil if arguments are invalid, or false if limit of up to 48 shadows reach. size of shadow should not be greater than 64x64 units. the more shadows in the larger size, they started to be less precise.
if shadowType skipped, plain color will used
they are small graphical glitches at connetion of triangles
-X, 0, 0, X
is shadow X units in all 4 directionAll allowed shadows types are below
Example script:
Screenshots:



"car", "ped", "heli", "bike", "rcbaron", "explosion", "headlight1", "headlight2", "blood", "headman", "wincrack", "lamp"
from left to right