Encode todo add/tag actions as URL-safe base64 JSON payloads#802
Open
multiplex55 wants to merge 3 commits intomasterfrom
Open
Encode todo add/tag actions as URL-safe base64 JSON payloads#802multiplex55 wants to merge 3 commits intomasterfrom
multiplex55 wants to merge 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
todo:add:andtodo:tag:actions can carry arbitrary text and tags (including|,,, and whitespace) without ambiguous delimiter parsing.Description
TodoAddActionPayloadandTodoTagActionPayloadand shared encode/decode helpers that serialize to JSON and encode using URL-safe base64. (src/plugins/todo.rs)TodoPluginto serialize add/tag arguments intotodo:add:<encoded>andtodo:tag:<encoded>when buildingAction.action. (src/plugins/todo.rs)parse_action_kindto decode those payloads and returnActionKind::TodoAdd/ActionKind::TodoSetTagsfrom the deserialized values. (src/launcher.rs)ActionKind::TodoAdd.textto own aStringso decoded payload text can be carried safely, and adjusted the launch path to calltodo::add(&text, priority, &tags). (src/launcher.rs)|,,, and whitespace in both the plugin and launcher parser. (src/plugins/todo.rs,src/launcher.rs)Testing
cargo fmt --allwhich completed successfully.cargo test --all-targetsbut the full test run failed in this environment due to a missing system dependency required byalsa-sys(pkg-config /alsa.pc), so tests could not complete; the added unit tests are included in the tree and will run in CI or on a machine with the ALSA dev package available.Codex Task