Skip to content

Add visibility change logs #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
multiplex55 merged 1 commit into from
Jun 8, 2025
Merged

Add visibility change logs #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,9 @@ fn main() -> anyhow::Result<()> {
}

if trigger.take() {
let next = !visibility.load(Ordering::SeqCst);
tracing::debug!("trigger.take -> next visibility: {}", next);
let old = visibility.load(Ordering::SeqCst);
let next = !old;
tracing::debug!(from=?old, to=?next, "visibility updated");
visibility.store(next, Ordering::SeqCst);
if let Ok(mut guard) = ctx.lock() {
if let Some(c) = &*guard {
Expand All @@ -166,7 +167,9 @@ fn main() -> anyhow::Result<()> {
} else if let Some(next) = queued_visibility {
if let Ok(mut guard) = ctx.lock() {
if let Some(c) = &*guard {
tracing::debug!("applying queued visibility: {}", next);
let old = visibility.load(Ordering::SeqCst);
visibility.store(next, Ordering::SeqCst);
tracing::debug!(from=?old, to=?next, "visibility updated");
c.send_viewport_cmd(egui::ViewportCommand::Visible(next));
c.request_repaint();
queued_visibility = None;
Expand Down
7 changes: 6 additions & 1 deletion src/visibility.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ pub fn handle_visibility_trigger<C: ViewportCtx>(
queued_visibility: &mut Option<bool>,
) {
if trigger.take() {
let next = !visibility.load(Ordering::SeqCst);
let old = visibility.load(Ordering::SeqCst);
let next = !old;
tracing::debug!(from=?old, to=?next, "visibility updated");
visibility.store(next, Ordering::SeqCst);
if let Ok(mut guard) = ctx_handle.lock() {
if let Some(c) = &*guard {
Expand All @@ -45,6 +47,9 @@ pub fn handle_visibility_trigger<C: ViewportCtx>(
} else if let Some(next) = *queued_visibility {
if let Ok(mut guard) = ctx_handle.lock() {
if let Some(c) = &*guard {
let old = visibility.load(Ordering::SeqCst);
visibility.store(next, Ordering::SeqCst);
tracing::debug!(from=?old, to=?next, "visibility updated");
c.send_viewport_cmd(egui::ViewportCommand::Visible(next));
c.request_repaint();
*queued_visibility = None;
Expand Down