Skip to content

Ensure case-insensitive contains checks #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
multiplex55 merged 1 commit into from
Jul 16, 2025
Merged

Ensure case-insensitive contains checks #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/clipboard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,12 @@ impl Plugin for ClipboardPlugin {
.collect();
}

let filter = trimmed[PREFIX.len()..].trim();
let filter = trimmed[PREFIX.len()..].trim().to_lowercase();
let history = self.update_history();
history
.iter()
.enumerate()
.filter(|(_, entry)| entry.contains(filter))
.filter(|(_, entry)| entry.to_lowercase().contains(&filter))
.map(|(idx, entry)| Action {
label: entry.clone(),
desc: "Clipboard".into(),
Expand Down
6 changes: 3 additions & 3 deletions src/plugins/history.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::actions::Action;
use crate::plugin::Plugin;
use crate::history::get_history;
use crate::plugin::Plugin;

const MAX_HISTORY_RESULTS: usize = 10;

Expand All @@ -20,11 +20,11 @@ impl Plugin for HistoryPlugin {
args: None,
}];
}
let filter = query[PREFIX.len()..].trim();
let filter = query[PREFIX.len()..].trim().to_lowercase();
get_history()
.into_iter()
.enumerate()
.filter(|(_, entry)| entry.query.contains(filter))
.filter(|(_, entry)| entry.query.to_lowercase().contains(&filter))
.take(MAX_HISTORY_RESULTS)
.map(|(idx, entry)| Action {
label: entry.query,
Expand Down
8 changes: 4 additions & 4 deletions src/plugins/tempfile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,15 @@ impl Plugin for TempfilePlugin {
if trimmed.len() >= RM_PREFIX.len()
&& trimmed[..RM_PREFIX.len()].eq_ignore_ascii_case(RM_PREFIX)
{
let filter = trimmed[RM_PREFIX.len()..].trim();
let filter = trimmed[RM_PREFIX.len()..].trim().to_lowercase();
let files = list_files().unwrap_or_default();
return files
.into_iter()
.filter(|p| {
filter.is_empty()
|| p.file_name()
.and_then(|n| n.to_str())
.map(|n| n.contains(filter))
.map(|n| n.to_lowercase().contains(&filter))
.unwrap_or(false)
})
.map(|p| Action {
Expand Down Expand Up @@ -219,15 +219,15 @@ impl Plugin for TempfilePlugin {
if trimmed.len() >= LIST_PREFIX.len()
&& trimmed[..LIST_PREFIX.len()].eq_ignore_ascii_case(LIST_PREFIX)
{
let filter = trimmed[LIST_PREFIX.len()..].trim();
let filter = trimmed[LIST_PREFIX.len()..].trim().to_lowercase();
let files = list_files().unwrap_or_default();
return files
.into_iter()
.filter(|p| {
filter.is_empty()
|| p.file_name()
.and_then(|n| n.to_str())
.map(|n| n.contains(filter))
.map(|n| n.to_lowercase().contains(&filter))
.unwrap_or(false)
})
.map(|p| Action {
Expand Down