mptcp: tfo: add basic server side coverage #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are similar to the ones for the client side: a first connection is established without DATA in the SYN to request a key, then new connections can send DATA in the SYN with the cookie it previously received. Ideally we would like to validate a second connection in the same test but we are limited by Packetdrill here which cannot understand the new SYN is for a new connection. So this test is split in two parts: - server-TCP_FASTOPEN-cookie-req: the first connection, cookie request - server-TCP_FASTOPEN-cookie-data: the cookie has already been exchanged, data can be sent with the cookie. Note that we can also not use the cookie by setting a sysctl and directly send data, that's what "server-tfo-no-cookie" is doing. Equivalent tests for (plain) TCP are also added. Note that kernel patches are required to get the expected cookie in IPv6, see: multipath-tcp/mptcp_net-next#317 Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
dcaratti
approved these changes
Dec 2, 2022
|
Thank you for the reviews! I hope you don't mind if I revert this one because we need a fix in the kernel, see:
I will re-apply them when merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are similar to the ones for the client side: a first connection is established without DATA in the SYN to request a key, then new connections can send DATA in the SYN with the cookie it previously received.
Ideally we would like to validate a second connection in the same test but we are limited by Packetdrill here which cannot understand the new SYN is for a new connection.
So this test is split in two parts:
Note that we can also not use the cookie by setting a sysctl and directly send data, that's what "server-tfo-no-cookie" is doing.
Equivalent tests for (plain) TCP are also added.
Note that kernel patches are required to get the expected cookie in IPv6, see:
multipath-tcp/mptcp_net-next#317