Migrate build and serve to use vite instead of using webpack #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for next-multilink ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
1 task
kirangadhave
added a commit
to visdesignlab/trrack
that referenced
this pull request
Dec 16, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
No
Give a longer description of what this PR addresses and why it's needed
This speeds up our build step, serve step, and uses the current suggestions from vue for our build system. This will help with our migration to vue 3, pinia, and vuetify 3 when they are ready.
This switch to vite allows us to remove a ton of dependencies, such as babel, vue-cli, etc. This reduces the complexity of the app and the security risks of our dependencies.
These changes drops our build time from 30-60 to less than a second, 248ms on my last build. Incremental builds are also faster, but not as notably.
Provide pictures/videos of the behavior before and after these changes (optional)
No change to the UI, it's all in the code.
Are there any additional TODOs before this PR is ready to go?
TODOs:
"module": "dist/trrack.esm.js"and"module": "dist/trrackvis.esm.js", respectively, in their package.jsons.