Skip to content

Conversation

@JackWilb
Copy link
Member

@JackWilb JackWilb commented Jun 16, 2022

Does this PR close any open issues?

Closes #295

Give a longer description of what this PR addresses and why it's needed

This allows for breaking scales when we have outliers on the extreme high and low end of the data. This means that the data fits into the view better

As suggested in #295, I use the IQR to calculate a cut off and break the scales there.

Provide pictures/videos of the behavior before and after these changes (optional)

All clip regions active:
image

Just high clip regions active:
image

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • Applying 2 layouts (x and y) seems to be broken
  • Allow using different scale types (log, etc.). Probably open new issue + PR for this (Allow changing the scales for the layout variables #315)
  • Make sure nodes release when there's no layout applied (maybe reset marker size + label?)
  • Verify low and high clipping work as intended
  • Add label for nodes outside of range
  • Decide if IQR is best metric (IQR would give outliers on normal distributed data, but maybe that's okay. Check with Alex) (Allow user defined outlier range for attribute drive layout #316)
  • Make clipRegions larger (now larger and tunable by changing 1 variable. Check with team on Monday for confirmation that they're large enough)
  • Plot the outliers in the order they are in the data

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for next-multilink ready!

Name Link
🔨 Latest commit 4fd664b
🔍 Latest deploy log https://app.netlify.com/sites/next-multilink/deploys/62ba109a72f6f800099569d3
😎 Deploy Preview https://deploy-preview-314--next-multilink.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JackWilb JackWilb marked this pull request as ready for review June 27, 2022 01:33
@JackWilb JackWilb force-pushed the break-layout-scales branch from 7e14593 to d28d72e Compare June 27, 2022 14:51
@JackWilb JackWilb merged commit e44099e into main Jun 27, 2022
@JackWilb JackWilb deleted the break-layout-scales branch June 27, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Break scales when the data has outliers

1 participant