Hash and Multihash arbitrary #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
added a commit
to Actyx/rust-cid
that referenced
this pull request
Feb 20, 2020
This is incomplete as long as multiformats/rust-multihash#51 is not merged
|
Note that the tests that I have added in this crate using the arbitrary are in the files themselves. The tests directory is for integration tests that use the crate externally, so there is not an easy way to enable the test feature for them, except maybe doing it on a file by file basis as outlined here: rust-lang/cargo#2911 (comment) |
rklaehn
force-pushed
the
actyx/multihash-arbitrary
branch
from
de95467 to
41266ec
Compare
rklaehn
commented
Feb 21, 2020
| @@ -25,3 +25,12 @@ sha1 = "0.5" | |||
| sha2 = { version = "0.7", default-features = false } | |||
| tiny-keccak = "1.4" | |||
| unsigned-varint = "0.3" | |||
There was a problem hiding this comment.
We need the dependencies twice, once for our own tests, and once for the test feature that other crates can use from their dev-dependencies.
rklaehn
force-pushed
the
actyx/multihash-arbitrary
branch
from
41266ec to
e57e035
Compare
Both for internal purposes and for use by other crates
rklaehn
force-pushed
the
actyx/multihash-arbitrary
branch
from
e57e035 to
f73a232
Compare
|
@vmx brought this up to date. WDYT? I would love the entire multiformats crate hierarchy to have arbs so that more complex crates such as rust-ipfs or rust-libp2p can use them to write property based tests / fuzz tests. |
vmx
approved these changes
Mar 2, 2020
vmx
approved these changes
Mar 2, 2020
dignifiedquire
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #48
This is a request for discussion about if this way of providing arbitraries both for internal use and for use from other crates is a good way to go.
If somebody has a simpler way to achieve this I am eager to hear about it...
I verified that the dependencies are not in the output unless you build with the feature flag enabled. See https://github.com/rklaehn/rust-feature-experiment
This is based on #47 , so should be reviewed once that is merged.