Sync multiaddr codecs #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Co-authored-by: Max Inden <mail@max-inden.de>
rvagg
approved these changes
Sep 29, 2022
We're using it in multiaddrs so that clients can set the SNI of a TLS handshake even if they've already resolved the domain name to an ip address. See: multiformats/multiaddr#138 (comment) and libp2p/go-libp2p#1719 (comment). It's also part of the multiaddr README so the idea has been around for a while. |
marten-seemann
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three codecs were defined in the multiaddr repo but not here. This syncs up the codec tables. I also added a checker to the multiaddr repo that will flag when this happens again in the future (multiformats/multiaddr#142).