remove base1 #57
Closed
remove base1 #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Jul 25, 2019
Stebalien
commented
- It's not used anywhere.
- It's absolutely useless.
- It's making our lives harder in libp2p (inline peer IDs currently start with 1).
1. It's not used anywhere. 2. It's absolutely useless. 3. It's making our lives harder in libp2p (inline peer IDs currently start with 1).
raulk
approved these changes
Jul 26, 2019
raulk
requested changes
Jul 26, 2019
Member
There was a problem hiding this comment.
@Stebalien I’d say we need to reserve codepoint 1 explicitly, explaining why (causes ambiguity with ed25519 peer IDs encoded as CIDv1). Basically a vestigial collision.
Member
Author
|
Well, that and Q. But we'd like to eventually be able to simply drop both. |
daviddias
approved these changes
Jul 26, 2019
Merged
Member
Author
|
Merged in #47. |
Stebalien
added a commit
to multiformats/js-multibase
that referenced
this pull request
Jul 26, 2019
We've removed it from the multibase spec: * multiformats/multibase#48 * multiformats/multibase#57
Stebalien
added a commit
to multiformats/go-multibase
that referenced
this pull request
Jul 26, 2019
Stebalien
added a commit
to Stebalien/kotlin-multibase
that referenced
this pull request
Jul 26, 2019
Base1 has been removed from the spec for compatibility/uselessness reasons: * multiformats/multibase#57 * multiformats/multibase#47
Stebalien
added a commit
to multiformats/java-multibase
that referenced
this pull request
Jul 26, 2019
Base1 has been removed from the spec for compatibility/uselessness reasons: * multiformats/multibase#57 * multiformats/multibase#47
Stebalien
added a commit
to multiformats/haskell-multibase
that referenced
this pull request
Jul 26, 2019
Base1 has been removed from the spec for compatibility/uselessness reasons: * multiformats/multibase#57 * multiformats/multibase#47
Stebalien
added a commit
to Stebalien/scala-multibase
that referenced
this pull request
Jul 26, 2019
Stebalien
added a commit
to multiformats/js-multibase
that referenced
this pull request
Jul 26, 2019
We've removed it from the multibase spec: * multiformats/multibase#48 * multiformats/multibase#57 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
added a commit
to Stebalien/ex-multibase
that referenced
this pull request
Jul 26, 2019
We've removed it from the multibase spec: * multiformats/multibase#48 * multiformats/multibase#57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.