fix: precalculate multiaddr parts #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Jul 28, 2023
achingbrain
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
## [12.1.4](v12.1.3...v12.1.4) (2023-07-28) ### Bug Fixes * precalculate multiaddr parts ([#330](#330)) ([cf7e9c6](cf7e9c6)), closes [#329](#329) ### Trivial Changes * update project config ([#326](#326)) ([76fa6f5](76fa6f5)) ### Documentation * import from @multiformats/multiaddr ([#327](#327)) ([4dedd4b](4dedd4b)) ### Dependencies * bump multiformats from 11.0.2 to 12.0.1 ([#328](#328)) ([07d4f8a](07d4f8a)) * **dev:** bump aegir from 39.0.13 to 40.0.2 ([#333](#333)) ([3480741](3480741))
|
🎉 This PR is included in version 12.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking #329 to its logical extreme, we're able to simplify the codebase (mostly
codec.tsand its interaction withDefaultMultiaddr).Precalculate a
MultiaddrPartswhen constructing aDefaultMultiaddr.MultiaddrPartsis essentially an object containing all data which is stored in aDefaultMultiaddr.This makes all
DefaultMultiaddrmethods cheap, at the expense of always storing the string, bytes, tuples, stringTuples, and path of the multiaddr.The two important functions to review are
stringToMultiaddrPartsandbytesToMultiaddrParts, which convert untrusted string and bytes intoMultiaddrParts.cc @tuyennhv