Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ip6zone #226

Merged
merged 5 commits into from
Jan 17, 2023
Merged

feat: support ip6zone #226

merged 5 commits into from
Jan 17, 2023

Conversation

vogdb
Copy link
Contributor

@vogdb vogdb commented Feb 18, 2022

Hi! This PR is not yet ready to merge. Some questions need to be clarified. Please look.

  • Should be the same test data used here as in go-multiaddr? Or better add more test data?
  • Should Multiaddr.nodeAddress also support 'ip6zone'? Currently it will throw on any address with 'ip6zone'.

The specs PR is multiformats/multiaddr#68 for reference.

@vogdb vogdb mentioned this pull request Feb 18, 2022
Closed
github-actions bot pushed a commit that referenced this pull request Jan 6, 2023
@semantic-release-bot
chore(release): 11.1.5 [skip ci]
c04b04f 
## [11.1.5](v11.1.4...v11.1.5) (2023-01-06)

### Dependencies

* bump multiformats from 10.0.3 to 11.0.0 ([#301](#301)) ([f52b85a](f52b85a)), closes [#234](#234) [#226](#226) [#234](#234) [#226](#226) [#226](#226)

### Documentation

* update readme ([6f1df24](6f1df24))
@achingbrain achingbrain marked this pull request as draft January 10, 2023 16:53
@achingbrain
Copy link
Member

This PR is not yet ready to merge

I have converted this PR to a draft

@achingbrain
Copy link
Member

Should be the same test data used here as in go-multiaddr? Or better add more test data?

Yes, but this can be done in a follow up PR

Should Multiaddr.nodeAddress also support 'ip6zone'? Currently it will throw on any address with 'ip6zone'.

Yes, I think it should - I've updated this PR to do that

@achingbrain achingbrain marked this pull request as ready for review January 17, 2023 13:09
@achingbrain achingbrain merged commit cfacedb into multiformats:master Jan 17, 2023
github-actions bot pushed a commit that referenced this pull request Jan 17, 2023
@semantic-release-bot
chore(release): 11.3.0 [skip ci]
4a7c850 
## [11.3.0](v11.2.0...v11.3.0) (2023-01-17)

### Features

* support ip6zone ([#226](#226)) ([cfacedb](cfacedb)), closes [#134](#134)
@github-actions
Copy link

🎉 This PR is included in version 11.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vogdb @achingbrain