Add lookup for multicodec code by string name #40
Conversation
willscott
commented
Mar 19, 2021
willscott
commented
- update generate to run with local stringer
- fix Allow lookup of code from name #39
* update generate to run with local stringer
There was a problem hiding this comment.
Initially I didn't add the string->Code mapping API because I didn't have an immediate need for it, and because I thought that most users would only need to know about a few input multicodec strings.
It was only a matter of time before we added this, though. I do think the old API was far too bloated, but this addition seems reasonable on its own.
FYI @warpfork
| //go:generate stringer -type=Code -linecomment | ||
| //go:generate go get golang.org/x/tools/cmd/stringer | ||
| //go:generate go run golang.org/x/tools/cmd/stringer -type=Code -linecomment | ||
| //go:generate go mod tidy |
There was a problem hiding this comment.
Clever :) I personally prefer to not do hacks like these until golang/go#42088 is fixed (likely in Go 1.17), but having to remember to set up stringer is also a bit of a hack.
I also slightly lean towards not having it this way, since go generate editing or tidying the current module seems a bit surprising. No strong opinion, though.
There was a problem hiding this comment.
i do like that it works and doesn't need stringer on the user path since that's not something I want to always have.
I'll file an issue to revisit once go 1.17 is out, but leave it like this from now.
