flesh out resolution logic and support /dns #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Stebalien
added a commit
to multiformats/go-multiaddr
that referenced
this pull request
Sep 19, 2019
This is a defacto standard and is used by js-libp2p. Ported from multiformats/go-multiaddr-dns#17. This was decided in multiformats/multiaddr#22.
1. Handle multiple dns{4,6,addr} anywhere in an address.
2. Try to allocate less.
Stebalien
force-pushed
the
feat/rewrite
branch
from
835ae1f
to
8c560f5
Compare
Stebalien
commented
Sep 19, 2019
| if protos[0].Code == p.Code { | ||
| return true | ||
| func Matches(maddr ma.Multiaddr) (matches bool) { | ||
| ma.ForEach(maddr, func(c ma.Component) bool { |
There was a problem hiding this comment.
This version doesn't allocate.
| ip4maddr, err := ma.NewMultiaddr("/ip4/" + ip4.String()) | ||
| if err != nil { | ||
| return result, err | ||
| var results []ma.Multiaddr |
There was a problem hiding this comment.
Support resolving /dns[46] anywhere in an address, multiple times. Currently, we'll only resolve this at the beginning of the address.
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we now support addresses like:
Note: We still can't specify dnsaddr anywhere except the end, unfortunately.