Correctly format extra event keys to have them parsed by Cloud Logging #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra keys are not added to `logging.googleapis.com/labels` as it's some kind of special (I'll add a formatter to add extra labels in there). Instead, the extra keys are simply added as extra JSON keys when formatted to stdout, and they will be picked up by Google Cloud Logging and added as extra keys into the final Cloud Logging event's `jsonPayload` key Only downside: when there are no extra keys, Cloud Logging simply put the log message into `textPayload` and not into `jsonPayload.message`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra keys are not added to
logging.googleapis.com/labelsas it's some kind of special (I'll add a formatter to add extra labels in there).Instead, the extra keys are simply added as extra JSON keys when formatted to stdout, and they will be picked up by Google Cloud Logging and added as extra keys into the final Cloud Logging event's
jsonPayloadkeyOnly downside: when there are no extra keys, Cloud Logging simply put the log message into
textPayloadand not intojsonPayload.message.