Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'Album Artist' view in the library #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sammko
Copy link

@sammko sammko commented Jun 19, 2015

I implemented an Album Artist library view (#82). I am, however, having one problem with this patch, which I cannot figure out how to fix. When I select the view in the library, I end up with an Untagged entry at the bottom of the list, which fails to open. Thanks for any help with that.

@multani
Copy link
Owner

multani commented Jun 21, 2015

Hi,

Thanks for the patch and for diving into library.py 😰 I'm just to skim over the patch, since the code (in Sonata) is really horrendous, and needs a huge, huge, huge refactoring.

So, I tested your branch, and it seems there's still some problem.

First, I can't find my tracks which are tagged with the albumartist tag correctly set (I use Various Artists), the albums simply don't appear in Sonata.
Also, I also have the "Untagged" entry, which I think should just not be here.

I can try to have a look at the code to see where your problem is, but that will take some time.

(Probably an easier way, if you are into it, would be to first refactor the library module, then implement your new functionality 😁 If you are interested or curious, just drop me an email and I can give you some guidance before you start.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants