Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-17615532: Add unit test coverage for package org.mule.runtime.core.api.config #14255

Merged
merged 16 commits into from
Feb 26, 2025

Conversation

mbuchwald
Copy link
Contributor

No description provided.

@mbuchwald mbuchwald requested a review from a team as a code owner February 24, 2025 18:34
@mbuchwald
Copy link
Contributor Author

--validate

2 similar comments
@mbuchwald
Copy link
Contributor Author

--validate

@mbuchwald
Copy link
Contributor Author

--validate

Comment on lines 724 to 729
"ignore": true,
"code": "java.method.exception.checkedRemoved",
"old": "method org.mule.runtime.core.api.util.queue.QueueConfiguration org.mule.runtime.core.api.config.QueueProfile::configureQueue(java.lang.String, org.mule.runtime.core.api.util.queue.QueueManager) throws org.mule.runtime.api.lifecycle.InitialisationException",
"new": "method org.mule.runtime.core.api.util.queue.QueueConfiguration org.mule.runtime.core.api.config.QueueProfile::configureQueue(java.lang.String, org.mule.runtime.core.api.util.queue.QueueManager)",
"exception": "org.mule.runtime.api.lifecycle.InitialisationException",
"justification": "W-17615532: Code smells fixes for org.mule.runtime.core.api.config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed if the exception wasn't actually removed?

@mbuchwald mbuchwald enabled auto-merge (squash) February 26, 2025 13:51
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 75.0% Line Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@mbuchwald mbuchwald merged commit cefa3f6 into master Feb 26, 2025
7 of 8 checks passed
@mbuchwald mbuchwald deleted the W-17615532 branch February 26, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants