W-16629236: Cannot convert MessagingException to JSON using DW #14195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
--validate |
1 similar comment
|
--validate |
fsgonz
reviewed
Feb 5, 2025
| try { | ||
| getDetailedFailuresMethod = RoutingResult.class.getMethod("getFailuresWithExceptionInfo"); | ||
| detailedFailures = | ||
| (Map<String, Pair<Error, EventProcessingException>>) getDetailedFailuresMethod.invoke(routingResult); | ||
| (Map<String, Pair<Error, MuleException>>) getDetailedFailuresMethod.invoke(routingResult); |
There was a problem hiding this comment.
This is the only cast to EventProcessingException that we have in the code, right?
There was a problem hiding this comment.
If the tests pass, please monitor anyway uber during a week to see if something related to this is failing that was not caught by hawk.
There was a problem hiding this comment.
I think this is the only case it brings an issue.
core/src/main/java/org/mule/runtime/core/privileged/routing/RoutingResult.java
Show resolved
Hide resolved
core/src/main/java/org/mule/runtime/core/internal/routing/result/CompositeRoutingException.java
Show resolved
Hide resolved
| Map<String, Pair<Error, MuleException>> failedRoutesErrorWithExceptionMap = errorMap.entrySet().stream() | ||
| .collect(Collectors | ||
| .toMap(Entry::getKey, | ||
| pair -> new Pair<>(pair.getValue().getFirst(), getRootMuleException(pair.getValue().getSecond())))); |
There was a problem hiding this comment.
Why are you adding getRootMuleException here?
There was a problem hiding this comment.
See previous comment.
|
SonarQube Quality Gate
|
|
--validate |
fsgonz
approved these changes
Feb 6, 2025
IvanAndresFritzler
approved these changes
Feb 6, 2025
marianorean
changed the title
marianorean
added a commit
that referenced
this pull request
Feb 7, 2025
(cherry picked from commit 8bff808)
marianorean
added a commit
that referenced
this pull request
Feb 7, 2025
(cherry picked from commit 8bff808)
marianorean
added a commit
that referenced
this pull request
Feb 10, 2025
aiannucci
pushed a commit
that referenced
this pull request
Feb 10, 2025
…14195) Signed-off-by: Alejandro Iannucci <4360246+aiannucci@users.noreply.github.com>
marianorean
added a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.