Should Token type have `expires` property?

[moltar]

From console.log it does appear that this property is available, but it is not exposed.

Is it a private property or can it be made public?

{
      // ... snip

      tokenType: 'bearer',
      accessToken: '...',
      refreshToken: '...',

      // THIS
      expires: 2020-08-05T10:54:20.704Z
}

https://github.com/mulesoft/js-client-oauth2/blob/a237644785b4910689dd72f1c5d6905fa3a88ae7/index.d.ts#L61-L72

[jasonterando]

Seconded. We need a mechanism to renew the token before it expires

[ErwinSteffens]

Bumping this one. Really needed!

Maybe add a timespan to the expired method like:

/**
 * Check whether the token has expired.
 *
 * @return {boolean}
 */
ClientOAuth2Token.prototype.expired = function (marginSeconds) {
  var expireTime = this.expires.getTime()
  if (marginSeconds) {
    expireTime -= marginSeconds;
  }
  return Date.now() > expireTime
}

[whatsrupp]

I'm just migrating our use of this library to typescript, we've been depending on the expires property to know when to call refresh on the token in a long running process.

So +1 for: "Is expires a private or public property?

If it's just a case of updating the types, then I'd happily open a PR

[edneypitta]

as a workaround I'm doing:

const expiresIn = parseInt(accessToken.data.expires_in) || 0;
accessToken.expiresIn(expiresIn - EXPIRATION_WINDOW_IN_SECONDS);

[saitho]

+1 for saving an expiry date instead of a expires_in number.
I'm serializing the token data and load it when needed, so the expiry time gets reinitialized every time I load the data into the Oauth2 object. ^^

[mgara]

@ErwinSteffens is it expireTime -= marginSeconds or expireTime += marginSeconds ??
I did a fork ... I'm about to create a PR with the second option but you mentioned the expireTime -= marginSeconds so I'm like a little bit confused ... :D