Skip to content

Conversation

@muir
Copy link
Owner

@muir muir commented Jul 26, 2024

This bumps the minimum go version to 1.20 so that the mysql driver can be upgraded

@codecov
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (4d6362e) to head (7136741).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   73.83%   83.70%   +9.87%     
==========================================
  Files          12       12              
  Lines        1261     1080     -181     
==========================================
- Hits          931      904      -27     
+ Misses        267      102     -165     
- Partials       63       74      +11     
Flag Coverage Δ
go_tests 9.25% <ø> (+0.13%) ⬆️
mysql_tests 51.66% <ø> (+1.62%) ⬆️
pg_tests 52.89% <ø> (+1.68%) ⬆️
singlestore_tests 47.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muir muir temporarily deployed to singlestore July 26, 2024 05:01 — with GitHub Actions Inactive
@muir muir merged commit 84ca8d7 into main Jul 26, 2024
@muir muir deleted the upgradeMysql branch July 26, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants