Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Experiment with sticky column headers #9589

Closed
wants to merge 2 commits into from

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jul 6, 2023

This is a sticky column headers idea borrowed from #9171 and applied to our current virtualization engine.

Demo: https://deploy-preview-9589--material-ui-x.netlify.app/x/react-data-grid/virtualization/#column-virtualization

@cherniavskii cherniavskii added the component: data grid This is the name of the generic UI component, not the React module! label Jul 6, 2023
@romgrk
Copy link
Contributor

romgrk commented Jul 26, 2023

I'll probably pick this up soon.

Do you think we can implement all of this without breaking changes?

And do you think we should implement the fake scrollbars now? They bring some complexity, but the design change (scrollbar going up to the headers) is not going to be liked by everyone.

@cherniavskii
Copy link
Member Author

cherniavskii commented Jul 26, 2023

Do you think we can implement all of this without breaking changes?

Probably not, but we could try to change as little as possible.
Also, the "breaking change" definition in this case is a bit blurry depending on whether we treat DOM structure as a public API - I can imagine that we do some structural DOM changes and release them in a minor version if they are not too drastic 🙂

And do you think we should implement the fake scrollbars now? They bring some complexity, but the design change (scrollbar going up to the headers) is not going to be liked by everyone.

Apart from complexity, are there any other drawbacks?

@romgrk romgrk mentioned this pull request Aug 16, 2023
9 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 22, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cherniavskii cherniavskii deleted the sticky-column-header branch October 11, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants