Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Clean screenshots #9298

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Jun 12, 2023

To easily visualize all the screenshots, I moved them into a single folder with the following python script.

Python script
import os
import re

rootdir = "./test/regressions/screenshots/chrome/"
distdir = "./test/regressions/screenshots/overview/"

for subdir, dirs, files in os.walk(rootdir, topdown=True):
    for file in files:
            
        filePath = os.path.join(subdir, file)

        dirPath = re.sub(r'chrome/(.*)/(.*)', r'overview/\1_\2', filePath)
        print(dirPath)

        os.rename(filePath, dirPath)

For the data grid, I removed demos from pages with interaction since their layout is pretty standard to focus on the interaction aspect which is useless for screenshot comparison.

For pickers, We might want to go the other direction. Allows few pages

  • custom components
  • shortcuts
  • custom layout
  • calendar systems
  • date calendar
  • time clock
  • digital clock

For other pages might need to create a ....Snap.js demo to show fields in those scenario (in a single screenshot)

diasbled error read only
without value
without value

@alexfauquette alexfauquette added test core Infrastructure work going on behind the scenes labels Jun 12, 2023
@mui-bot
Copy link

mui-bot commented Jun 12, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9298--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 596.7 1,229 596.7 905.9 269.589
Sort 100k rows ms 686.5 1,068.9 686.5 919.72 131.889
Select 100k rows ms 254.8 356.5 307.3 299.06 38.123
Deselect 100k rows ms 162.5 323.2 234.1 247.5 62.553

Generated by 🚫 dangerJS against 67df549

@alexfauquette alexfauquette marked this pull request as ready for review June 16, 2023 11:33
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 12, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@michelengelen michelengelen changed the base branch from master to next November 6, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes PR: out-of-date The pull request has merge conflicts and can't be merged test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants