Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Allows having multiple playgrounds #5288

Merged
merged 1 commit into from
Jun 22, 2022
Merged

[DX] Allows having multiple playgrounds #5288

merged 1 commit into from
Jun 22, 2022

Conversation

alexfauquette
Copy link
Member

I most of the time have multiple playground examples:

  • One for the feature under development
  • On for doing debugging (or answer example) on locale

Ignoring a full folder should simplify switching between PR by keeping examples at different URLs. For example

@alexfauquette alexfauquette requested a review from a team June 22, 2022 10:09
@mui-bot
Copy link

mui-bot commented Jun 22, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 254.4 593.8 412.3 418.68 110.537
Sort 100k rows ms 586.1 960.2 890.3 840.98 132.447
Select 100k rows ms 130.1 287.3 206.4 203 50.665
Deselect 100k rows ms 160.7 201 191.7 186.02 14.67

Generated by 🚫 dangerJS against 3a8a1a6

@alexfauquette alexfauquette added the dx Related to developers' experience label Jun 22, 2022
@alexfauquette alexfauquette changed the title [DX] Ignore multiple playgrounds [DX] Allows having multiple playgrounds Jun 22, 2022
@alexfauquette alexfauquette merged commit 769d583 into mui:master Jun 22, 2022
@alexfauquette alexfauquette deleted the improve-dx branch June 22, 2022 11:30
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@alexfauquette @joserodolfofreitas
[DX] Allows having multiple playgrounds (mui#5288)
92adaa5
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@alexfauquette
[DX] Allows having multiple playgrounds (mui#5288)
1fb31cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
dx Related to developers' experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexfauquette @mui-bot @flaviendelangle