[test] Use mock for ResizeObserver #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
m4theushw
force-pushed
the
mock-resize-observer
branch
from
81374e5 to
f7df3fc
Compare
cherniavskii
approved these changes
Jun 21, 2022
joserodolfofreitas
pushed a commit
to joserodolfofreitas/mui-x
that referenced
this pull request
Jul 15, 2022
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for dynamic row height kept failing after merging #5203. The problem is the same from #5095: all pass in headless mode but some fail in the non-headless Chrome. In this PR I take another approach by replacing
ResizeObserverfor a mocked version. It seem to have worked in https://app.circleci.com/pipelines/github/mui/mui-x/19851/workflows/d4541c25-0fd8-489c-bf0a-acaaf01e2e25/jobs/115292