Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Remove utils and value params from translations #14986

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[pickers] Remove utils and value params from translations #14986

wants to merge 5 commits into from
+424 −510

Conversation

arthurbalduini
Copy link
Member

Closes #14648

It's in draft since it should be merged once we start the v8 alpha version

@arthurbalduini arthurbalduini added breaking change component: pickers This is the name of the generic UI component, not the React module! v8.x labels Oct 15, 2024
@mui-bot
Copy link

mui-bot commented Oct 15, 2024 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-14986--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against b50ada1

@arthurbalduini arthurbalduini mentioned this pull request Oct 15, 2024
Open
5 tasks
flaviendelangle
flaviendelangle reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🙏

Can you take care of adding the migration guide (you can copy paste the doc page from #14651 and just replace the actual sections)?

Don't forget the small BC on PickersInputLocaleText which is public 👍

No codemod required here IMHO

@arthurbalduini
Copy link
Member Author

Don't forget the small BC on PickersInputLocaleText which is public 👍

I also mentioned other exported types that no longer receive a parameter.

flaviendelangle
flaviendelangle reviewed Oct 18, 2024
View reviewed changes
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
);
```

Also the following types and interfaces no longer receive a generic type parameter:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaking change will also be covered by #15001

We can keep it for now waiting for the more detailed section about the removal of TDate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] Remove utils and value params from translations
3 participants
@arthurbalduini @mui-bot @flaviendelangle