[infra] Create ESLint plugins renovate group
#14574
Conversation
LukasTy
added
core
renovate.json
Outdated
| @@ -53,6 +53,20 @@ | |||
| "groupName": "typescript-eslint", | |||
| "matchPackagePatterns": "@typescript-eslint/*" | |||
| }, | |||
| { | |||
| "groupName": "ESLint plugins", | |||
| "matchPackageNames": [ | |||
There was a problem hiding this comment.
What about enabling eslint-plugin-* and just skip eslint-plugin-react-compiler instead
There was a problem hiding this comment.
Is there a way to do it for a group config? 🤔
There was a problem hiding this comment.
We use the following rule in Toolpad
{
"groupName": "eslint",
"matchPackageNames": ["eslint"],
"matchPackagePatterns": ["^eslint-", "^@eslint/", "^@eslint-", "^@typescript-eslint/"]
},but you should also be able to just add a negative pattern
"matchPackagePatterns": ["eslint-plugin-*", "!eslint-plugin-react-compiler"]There was a problem hiding this comment.
@LukasTy you can negate pattern like !eslint-plugin-react-compiler
There was a problem hiding this comment.
And how do you deal with dependency bumping when eslint-plugin-react-compiler changes are very time consuming?
I would imagine that other ESLint dep bumping might be stuck for a while. 🙈
What do you mean?
This config is just for grouping, meaning eslint-plugin-react-compiler will still bump alone.
There was a problem hiding this comment.
This config is just for grouping, meaning
eslint-plugin-react-compilerwill still bump alone.
I meant the Toolpad config. 😉
In their case, it looks like the react-compiler plugin would be included in the same group...
There was a problem hiding this comment.
Negating didn't work, even though it is documented 🤔
https://docs.renovatebot.com/configuration-options/#matchpackagenames
There was a problem hiding this comment.
yeah... 🙈 😢
That's what I was afraid of. 😆
There was a problem hiding this comment.
Looks like my bad: #14577 🙈 🤦
|
Deploy preview: https://deploy-preview-14574--material-ui-x.netlify.app/ |
We don't have that plugin enabled by default. |
We have numerous
eslint-plugin-*dependencies that keep producing conflicts after merging one of the bump PRs.mui-x/package.json
Lines 144 to 154 in a198b26
Having them grouped should ease such bumps. 🤞