Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Fix charts benchmark workflow #14573

Merged
merged 5 commits into from
Sep 11, 2024
Merged

[code-infra] Fix charts benchmark workflow #14573

merged 5 commits into from
Sep 11, 2024

Conversation

JCQuintas
Copy link
Member

Build all libs to prevent new libs breaking workflow.

@JCQuintas JCQuintas added bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! scope: code-infra Specific to the core-infra product labels Sep 11, 2024
@JCQuintas JCQuintas self-assigned this Sep 11, 2024
@mui-bot
Copy link

mui-bot commented Sep 11, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14573--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 49f76a3

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #14573 will not alter performance

Comparing JCQuintas:fix-benchmarks-workflow (49f76a3) with master (1939c1c)

Summary

✅ 3 untouched benchmarks

@JCQuintas JCQuintas mentioned this pull request Sep 11, 2024
Merged
1 task
@JCQuintas JCQuintas enabled auto-merge (squash) September 11, 2024 10:21
LukasTy
LukasTy approved these changes Sep 11, 2024
View reviewed changes
.github/workflows/codspeed.yml Outdated Show resolved Hide resolved
@JCQuintas @LukasTy
Update .github/workflows/codspeed.yml
b2559a0 
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas JCQuintas enabled auto-merge (squash) September 11, 2024 11:01
@JCQuintas
Update .github/workflows/codspeed.yml
49f76a3 
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas JCQuintas merged commit a187afa into mui:master Sep 11, 2024
17 checks passed
@JCQuintas JCQuintas deleted the fix-benchmarks-workflow branch September 11, 2024 11:42
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request Sep 30, 2024
@JCQuintas @LukasTy
[code-infra] Fix charts benchmark workflow (mui#14573)
62b5fdb 
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
@mbreadmachine mbreadmachine mentioned this pull request Oct 5, 2024
Closed
This was referenced Oct 5, 2024
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Oct 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@JCQuintas JCQuintas

Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JCQuintas @mui-bot @LukasTy @alexfauquette