Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Avoid visual regression when using @mui/material@6 #14357

Merged

Conversation

cherniavskii
Copy link
Member

Extracted from #14142

When running visual regression tests with @mui/material@6 we had 5 demos with visual diffs: https://app.argos-ci.com/mui/mui-x/builds/23408

This PR applies styles to ensure that these 5 demos have no visual differences between @mui/material@5 and @mui/material@6.
The goal is to avoid manually checking the screenshots for false negatives.

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Aug 26, 2024
@mui-bot
Copy link

mui-bot commented Aug 26, 2024

Deploy preview: https://deploy-preview-14357--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 5e7dad5

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling it! 🙏 💯
The solution doesn't look ideal, but makes sense. 👍
I checked the existing element height situation—it's a mess... 🙈

@LukasTy LukasTy merged commit 1fadc9e into mui:master Aug 27, 2024
20 checks passed
@cherniavskii cherniavskii deleted the material-ui-v6-avoid-visual-regressions branch August 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants