[charts] Filter item outside the drawing area for perf #14281
+200
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
performance
component: charts
|
Deploy preview: https://deploy-preview-14281--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #14281 will improve performances by 70.56%Comparing Summary
Benchmarks breakdown
|
alexfauquette
commented
Aug 27, 2024
| @@ -1,5 +1,7 @@ | |||
| import * as React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
|
|
|||
| import type {} from '../typeOverloads'; | |||
There was a problem hiding this comment.
Otherwise TS was not understading that pro component have zoom options
alexfauquette
commented
Aug 27, 2024
Comment on lines
+168
to
+175
| if ( | ||
| result.x > xMax || | ||
| result.x + result.width < xMin || | ||
| result.y > yMax || | ||
| result.y + result.height < yMin | ||
| ) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
That, plus the line .filter((rectangle) => rectangle !== null); ar the only modification. in this function. The rest is an indentation diff leading to some prettier modification
alexfauquette
force-pushed
the
filter-with-zoom
branch
from
7f8dbdc
to
0c28f3f
Compare
alexfauquette
commented
Sep 12, 2024
| @@ -24,7 +24,7 @@ describe('ScatterChart', () => { | |||
| async () => { | |||
| const { findByText } = render( | |||
| <ScatterChart | |||
| xAxis={[{ data: xData }]} | |||
| xAxis={[{ data: xData, valueFormatter: (v) => v.toLocaleString('en-US') }]} | |||
There was a problem hiding this comment.
I don't know why but I had an issue on my computer. The default locale of .toLocaleString was not the same in the test and in the render (1 000 vs 1,000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that zooming on 5% of the data takes as much time to render than a full zoom out. The more we zoom the faster it should render since less elements are to plot
For Bar charts, zoning on 5% of a 1,000 bars (only shows 50 bars out of the 1,000) makes the rendering time move from 100ms to 28ms