[charts] Defaultize axis on top level useChartContainerProps
#13817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCQuintas
added
enhancement
JCQuintas
force-pushed
the
zoom-props-improvements
branch
from
a6abebb
to
2ea3ead
Compare
|
Deploy preview: https://deploy-preview-13817--material-ui-x.netlify.app/ |
| axis: AxisConfig<ScaleName, any, ChartsAxisProps>[] | undefined; | ||
| extremumGetters: { [K in CartesianChartSeriesType]?: ExtremumGetter<K> }; | ||
| axisDirection: 'x' | 'y'; | ||
| dataset: DatasetType | undefined; |
There was a problem hiding this comment.
Why does the dataset is added in the arguments, but not used?
JCQuintas
commented
Jul 12, 2024
| dataset: DatasetType | undefined; | ||
| zoomData?: { axisId: AxisId; start: number; end: number }[]; | ||
| }) { | ||
| const allAxis = normalizeAxis(inAxis, dataset, axisDirection); |
There was a problem hiding this comment.
@alexfauquette dataset is used here 🤔
alexfauquette
approved these changes
Jul 12, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to: #13726 (comment)