-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Use specific version for @mui/docs
dependency
#13760
Conversation
specifier: ^6.0.0-alpha.14 | ||
version: 6.0.0-dev.240424162023-9968b4889d(7g77v67zn53nen4txxrs63agbq) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why it was behaving like this—installing an older canary release, when a more recent next
is asked for. 🙈 🤷
Decided to use the next
tag to ensure a wanted dep version is installed.
P.S. I've noticed this uncommenting the alias in the next.config.mjs
and seen that it can't find SectionTitle
. 🤷
Also seeing #13746 raised some eyebrows as it also tries to downgrade the dep version. 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to use https://docs.renovatebot.com/configuration-options/#followtag to force a specific tag but keeping the version numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing this. 🙏
That could be an option, albeit one that requires us to not forget to update this setting when changing to a stable release. 🤔
That is an interesting option. WDYT @mui/code-infra?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13813 as it still wants to bump to a legacy canary release. 🙈
Deploy preview: https://deploy-preview-13760--material-ui-x.netlify.app/ |
webpackBaseConfig.js
Outdated
@@ -7,7 +7,6 @@ module.exports = { | |||
resolve: { | |||
modules: [__dirname, 'node_modules'], | |||
alias: { | |||
'@mui/docs': path.resolve(__dirname, './node_modules/@mui/monorepo/packages/mui-docs/src'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This did not seem to be used anywhere. 🤔 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe this is used by eslint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe this is used by eslint
How can we test if it is needed given that no ESLint
issues are triggered by removing it? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted this change for now as it seems that we critically need this change or removing the explicit @mui/docs
package altogether to fix this issue:
Screen.Recording.2024-07-11.at.17.55.30.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we test if it is needed given that no ESLint issues are triggered by removing it? 🤔
technically it is needed when relying on aliasing this package from the monorepo. it's working when you remove the webpack alias because the package is also installed in node_modules and there is a high chance it's compatible with the aliased version. remove it from package.json and I suspect eslint will break without this webpack alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Thanks for the clarification.
I've left the alias intact. 👌
90c412e
to
50d49dd
Compare
@mui/docs
dependency with next
tag@mui/docs
dependency
No description provided.