[data grid] Fix focus visible style on scrollbar #12402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: data grid
|
Deploy preview: https://deploy-preview-12402--material-ui-x.netlify.app/ |
romgrk
approved these changes
Mar 10, 2024
|
to be fair, scroll containers that are focusable have the outline when when focus-visible triggers: 
but I believe here we set the focus just to be able to handle keyboard events, so good to move forward 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick win, I noticed this by chance, providing an example in #12401. It's a small regression from #10059.
Before:
Screen.Recording.2024-03-10.at.17.30.37.mov
After:
Screen.Recording.2024-03-10.at.17.30.47.mov
Similar to mui/material-ui#9147 but also different. There are no focus rings for scroll containers, it's not what end-users expect.
BTW, great to see that the keyboard actually works, it doesn't on AG Grid 🙈, a positive differentiator 👍