Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Fix right-pinned columns misalignment #10668

Closed
wants to merge 1 commit into from
Closed

[DataGridPro] Fix right-pinned columns misalignment #10668

wants to merge 1 commit into from

Conversation

cherniavskii
Copy link
Member

Fixes #10238

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Column pinning Related to the data grid Column pinning feature labels Oct 13, 2023
@mui-bot
Copy link

mui-bot commented Oct 13, 2023

Deploy preview: https://deploy-preview-10668--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0fb2235

romgrk
romgrk reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@romgrk romgrk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More conflicts with sticky :|

(if you have non-layout bugs to fix between now and v7 it might be nicer to work on those, these bugs will need be fixed by sticky anyway)

@cherniavskii
Copy link
Member Author

This is a fix for what seems to be a rare use case (see #10238 (comment)).
I'm putting it on hold since it's not a blocker 👍🏻

@cherniavskii cherniavskii added the on hold There is a blocker, we need to wait label Oct 13, 2023
@michelengelen michelengelen changed the base branch from master to next November 6, 2023 14:21
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 16, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cherniavskii
Copy link
Member Author

Closed by #10059

@cherniavskii cherniavskii deleted the fix-right-pinned-column-padding branch January 16, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk left review comments

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Column pinning Related to the data grid Column pinning feature on hold There is a blocker, we need to wait PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Misaligned header and cells for pinned columns
3 participants
@cherniavskii @mui-bot @romgrk