[data grid] Why was `onRowsScrollEnd` deprecated?

[chbiel]

While updating to MUI X 8 we found that onRowsScrollEnd was marked deprecated but without any reasoning.

Related commit: 22add0f#diff-8a13b4c3c289cbe969025c94cf8951384fa71c5afb14307233773cf4df72ddf1R1022-R1024

Could someone explain, why it was marked deprecated?
Removing it lowers flexibility of how to use the DataGrid and kind of forces into the use of GridDataSource what feels unfortunate.

Maybe @michelengelen as you introduced the deprecation in the above commit?

Thanks in advance!

Search keywords:

[michelengelen]

Hey @chbiel ... let me go over this real quick:

1. I did not deprecate the method, I simply changed the links in the docs to point to a different URL
2. This was deprecated in favor of the Infinite Loading feature

You should open an issue in the MUI-X repo, not here, since this is not the right place to do that. I'll transfer it over for you. For the reasoning I'll link @MBilalShafi who was the one building the server integration. He knows all the implications and problems around this topic more than I do.

[MBilalShafi]

While updating to MUI X 8 we found that onRowsScrollEnd was marked deprecated but without any reasoning.

Let me provide some context on the reasoning behind the deprecation.

With the introduction of Data Source, we aimed to offer a more robust and consistent approach to handling server-side data in the Data Grid. The goal was to streamline the API surface and reduce confusion by encouraging a single, unified way to manage data fetching.

Removing it lowers flexibility of how to use the DataGrid and kind of forces into the use of GridDataSource what feels unfortunate.

We understand that removing onRowsScrollEnd may reduce flexibility for some use cases, especially if you’re not using Data Source.

I'd be curious to know if you already tried Data Source Infinite Loading feature in your setup. If so, I’d be interested to hear about any challenges or limitations you encountered. If there’s a valid use case that Data Source doesn’t currently support, we’re open to revisiting the deprecation decision or considering alternative solutions.

Your feedback is valuable in shaping the API, so please feel free to share more details.

[chbiel]

@MBilalShafi thanks for the explaining. We already planned to try the approach in the next weeks and I will get back with feedback when we tried!

For us it's unforunate as we also used a similar onRowsScrollEnd approach before moving to the datagrid (we could switch back then without any code change).
So with this deprecation we have to change a long year, battle tested approach. I guess you can understand that we don't like that ;-)

[jansepke]

@MBilalShafi I am working together with chbiel and took a deeper look into the DataSource feature today. This is the current situation that we are working in:

1. we are building a company internal UI component library on top of MUI X with multiple different teams building applications on top of it
2. we wrapped the MUI X DataGrid in our own DataGrid component focused on server side data handling (using these props: sortModel, rows, loading, onRowsScrollEnd, onSortModelChange) so the current MUI X DataGrid declarative data API is part of our public API
3. the other teams are using multiple different data providers for the DataGrid (e.g. tanstack query, apollo, plain useEffect)
4. we are not using the filter features of the DataGrid but have a separate component that also relies on declarative data for its props

So to switch to the new DataSource we would need to: do a breaking change for our library so that all teams either replace theuer data providers with the MUI DataSource (unrealistic because something like tanstack query is integrated into multiple places in the application) or switch to an imperative approach like you proposed here #17906 (comment) (which is also a bigger rework)

I really like the general DataSource idea and would have used it if we would start from scratch but now it will take quite some time to shift to it. So please keep onRowsScrollEnd for a longer time