fix issue with button zdepth not being reset correctly #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-cea
added a commit
that referenced
this pull request
Oct 24, 2014
fix issue with button zdepth not being reset correctly Thanks Dan!
|
Thanks for the fix! :) |
DavidNgv
added a commit
to DavidNgv/material-ui
that referenced
this pull request
Dec 8, 2016
oliviertassinari
referenced
this pull request
in oliviertassinari/material-ui
Dec 2, 2017
eps1lon
added a commit
that referenced
this pull request
Jun 12, 2019
* Run danger on azure * Fix missing danger env variables
eps1lon
added a commit
that referenced
this pull request
Jun 12, 2019
* Run danger on azure * Fix missing danger env variables
eps1lon
added a commit
that referenced
this pull request
Jun 13, 2019
* Set up CI with Azure Pipelines [skip ci] * Persist snize snapshot (#10) * WIP * check on non-fork branch * Full impl * Dry run * Rerun * Look for credentials * Look again * The search continues * Maybe in global scope? * Inspect env * Full run * Dont persist on PR * Cleanup * Run danger on azure (#9) * Run danger on azure * Fix missing danger env variables * Run size snapshot exclusively on azure (#11) * Run size snapshot exclusively on azure * debug * Revert "debug" This reverts commit bff6dd2. * Fix empty size snapshot being persisted * Fix test_production CircleCi job * Poke azure * Add azure pipelines badge
eps1lon
added a commit
that referenced
this pull request
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for making material-ui. Here's a little fix for a bug I noticed.
Currently if you spam a bunch of clicks too quickly on the raised paper buttons, the button's z-index can break by increasing until it goes out of range. This happens because the var
originalZDepth(paper-button.jsx line 90) is supposed to always represent the initial z-depth of the button - however, it instead gets reset on every render, which means it really represents the current zDepth. If a second button click event happens before the previous click's onTransitionEnd is called, the already-incremented zDepth will be incremented again incorrectly and only decremented once.This should fix it by keeping an initialZDepth in this.state from the beginning and never touching it after that.