Skip to content

Conversation

@quanglam2807
Copy link
Contributor

This PR will make AppBar worked like Toolbar

<AppBar zDepth={1} noGutter={true}>
  <AppBarGroup key={0} style={{ float: 'left' }}>
    <IconButton onTouchTap={this._onLeftIconButtonTouchTap}>
       <FontIcon className="mui-icon-menu" />
    </IconButton>
    <AppBarTitle text={title}/>
  </AppBarGroup>
  <AppBarGroup key={1} style={{ float: 'right' }}>
    {githubButton}
  </AppBarGroup>
</AppBar>

Also, this will fix other related components: Toolbar, FontButton, FontIcon,...
Still WIP but please give reviews and comments.

@freeslugs
Copy link
Contributor

ooh +1 this would be a great feature.
can you post a pic of this in action? 😄

@quanglam2807 quanglam2807 changed the title [WIP] AppBar upgrade [WIP] AppBar DOM-like structures Jun 19, 2015
@quanglam2807 quanglam2807 changed the title [WIP] AppBar DOM-like structures [WIP] AppBar DOM-like structure Jun 19, 2015
@tleunen
Copy link

tleunen commented Jul 1, 2015

An update on this @quanglam2807 ? :)

@quanglam2807
Copy link
Contributor Author

@freeslugs Sorry for late response. Everything looks the same as the current app bar. 💃
@tleunen I'm quite busy these days. Anyway, I'm rebasing the PR right now. Just a few edits for CSS and documentations and it's ready to go. 👯

@quanglam2807
Copy link
Contributor Author

Moving to new branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: app bar Changes related to the app bar.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants