Make it possible to pass an onTouchTap handler to a dialog action #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialog actions could not react to the onTouchTap event. This commit makes it possible. It's also still possible to pass onClick. If neither onClick nor onTouchTap is present on an action, then the dialog is dismissed on touchTap.
There was a problem hiding this comment.
Not sure if we still need to document onClick here - passing onTouchTap always sounds like a better idea to me.
hai-cea
added a commit
that referenced
this pull request
Jun 5, 2015
Make it possible to pass an onTouchTap handler to a dialog action
|
Thanks @pomerantsev 👍 |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
Export Calendar and Day components for custom date pickers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialog actions could not react to the onTouchTap event.
This commit makes it possible.
It's also still possible to pass onClick.
If neither onClick nor onTouchTap is present on an action, then
the dialog is dismissed on touchTap.