[core] Simplify test suite and use vrtest for regressions #6122
Conversation
package.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "name": "material-ui-build", | |||
| "private": true, | |||
| "author": "Material-UI Team", | |||
| "version": "1.0.0-alpha.2", | |||
| "version": "1.0.0-alpha.1", | |||
| @@ -13,6 +13,8 @@ const globalStyleSheet = createStyleSheet('global', (theme) => { | |||
| }, | |||
| '*, *:before, *:after': { | |||
| boxSizing: 'inherit', | |||
| transition: 'none !important', | |||
| animation: 'none !important', | |||
.vscode/settings.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| // Place your settings in this file to overwrite default and user settings. | |||
There was a problem hiding this comment.
did you forget or intentionally commit settings file?
|
Tests (watch) are sooo much faster, that makes TDD much more appealing to do! |
.eslintignore
Outdated
| @@ -1,11 +1,6 @@ | |||
| node_modules | |||
| /build | |||
| /dist | |||
There was a problem hiding this comment.
I think that we still need it. Same for build. Well, that's only useful for people how publish to npm/work on the build process.
There was a problem hiding this comment.
Right. We can put them back then.
.eslintignore
Outdated
| /flow | ||
| /docs/site/build |
There was a problem hiding this comment.
Same, useful when I'm deploying the docs to firebase.
.gitignore
Outdated
| @@ -16,3 +16,4 @@ node_modules | |||
|
|
|||
| # Editor files | |||
| .idea | |||
| tmp | |||
There was a problem hiding this comment.
👍 still getting used to my new editor haha
There was a problem hiding this comment.
OT: What have you switched from / to?
There was a problem hiding this comment.
Sublime text to vscode
|
All good? @oliviertassinari @ArcanisCz |
|
One thing to note -- I took out ngrok to simplify things even further. You may or may not have an issue depending on how you have docker setup. For CI it is simple since on linux we have a proper bridge interface but the To solve this on my laptop, I have created an alias for the loopback interface using the instructions provided at https://docs.docker.com/docker-for-mac/networking/#/there-is-no-docker0-bridge-on-macos In our If this becomes problematic, I can add ngrok back to tunnel. |
|
@nathanmarks It seems good to me, but i have not much insight into majority of this configuration and not much say in matter anyway :) |
|
@nathanmarks Awesome 🎉 . |
oliviertassinari
changed the title
Simplifies test suite setup and replaces built-in regression tool with
vrtest.@oliviertassinari @mbrookes