(fix) Make touch-ripple properly react to touch events #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomerantsev
changed the title
|
Looks like this fix breaks EnhancedButton's onFocus behavior. I'll look into fixing it. |
mmrtnz
added a commit
that referenced
this pull request
Apr 24, 2015
(fix) Make touch-ripple properly react to touch events
|
Nothing appears to be broken when I tested it on my computer. Thank you for the submission @pomerantsev! |
This was referenced Apr 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542.
Not sure why such a check was performed:
e.pageX == undefined ? e.nativeEvent.pageX : e.pageX. If it's really possible for React's synthetic event not to get its properties from the native event, we should restore the check and add it for the touch event as well.