[docs] Fix RTL toggle highlight in docs settings drawer#48476
Merged
Conversation
sai6855
changed the title
sai6855
added
type: bug
Deploy previewhttps://deploy-preview-48476--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the docs settings drawer so the selected text-direction toggle reflects the actual direction state by propagating the current direction into the docs branding theme provider. In the broader docs app, this keeps useTheme() consumers aligned with the direction managed in ThemeOptionsContext.
Changes:
- Pass the current
directionprop fromBrandingCssVarsProviderintoBrandingCssThemeProvider. - Ensure components reading
theme.directioninside the docs shell, including the settings drawer toggle state, stay in sync with RTL/LTR changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
silviuaavram
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The left-to-right button remains highlighted even after selecting RTL in the settings drawer.
Before
After