[docs-infra] Remove infra around the i18n setup#48360
Merged
Merged
Conversation
brijeshb42
added
the
scope: docs-infra
Bundle size
Deploy previewhttps://deploy-preview-48360--material-ui.netlify.app/ Check out the code infra dashboard for more information about this PR. |
brijeshb42
force-pushed
the
docs-remove-i18n
branch
from
8cfc43f to
da41305
Compare
brijeshb42
commented
Apr 24, 2026
| workspaceRoot, | ||
| ignoreLanguagePages: LANGUAGES_IGNORE_PAGES, | ||
| languagesInProgress: LANGUAGES_IN_PROGRESS, | ||
| ignoreLanguagePages: () => false, |
Contributor
Author
There was a problem hiding this comment.
Keeping stubs for now. Will be fully cleaned up in the next PR.
mui.com is English-only, so the i18n regeneration entry point and its npm alias are dead weight. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mui.com only ships English, so the /:lang prefix logic, the LANGUAGES_SSR multi-traversal, the buildOnlyEnglishLocale deploy-preview shortcut, and the BUILD_ONLY_ENGLISH_LOCALE env flag were all scaffolding for a feature that does not exist. The markdown loader still receives no-op ignoreLanguagePages/languagesInProgress until we simplify core-docs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pageProps.userLanguage is always 'en' now that routing no longer threads a locale, so the prefix computation always resolves to an empty string. Inline the URLs and stop re-rendering productIdentifier on a value that cannot change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
docs and componentsApiDescriptions only ever contain an 'en' key now that the markdown loader and API docs builder stop emitting locale variants. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
next.config.ts no longer imports LANGUAGES*, so the re-export shim can go. LANGUAGES_LABEL in docs/src/modules/constants was never imported. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
brijeshb42
force-pushed
the
docs-remove-i18n
branch
from
da41305 to
49d9f77
Compare
Member
|
What's the plan forward? Should we also inline all translations again and get rid of the json files? In API docs, should we merge the labels into the api json files? |
Janpot
approved these changes
Apr 27, 2026
Contributor
Author
|
We can keep the json files. Its easier to generate and use/morph later on as well, regardless of i18n or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only cleans i18n related stuff in the
docs.To be followed up separately by cleanup in the
core-docspackage.