[codemod] Add --jsx option to v9.0.0/system-props codemod#48315
Merged
ZeeshanTamboli merged 4 commits intoApr 21, 2026
Conversation
Bundle size
Deploy previewCheck out the code infra dashboard for more information about this PR. |
siriwatknp
added
package: codemod
ZeeshanTamboli
approved these changes
Apr 18, 2026
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Left two comments. Rest looks good to me!
ZeeshanTamboli
changed the title
v9.0.0/system-props codemod
Co-authored-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
ZeeshanTamboli
approved these changes
Apr 21, 2026
Member
|
Looks good with the new change to support arbitrary components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #48269
Summary
The
v9.0.0/system-propscodemod relies on import detection to identify MUI components. This means it produces 0 changes in projects that use auto-import plugins (e.g.unplugin-auto-import) where components likeBox,Typography, etc. are globally available without explicit import statements.This PR adds a
--jsxoption that accepts a comma-separated list of JSX element names to treat as MUI components, bypassing import detection:For Reviewers
The
--jsxoption is passed as a codemod-specific flag (via--) rather than a global CLI option, following the existing pattern used by--component,--from,--toflags (see codemod.js L221).In
removeSystemProps.js, whenoptions.jsxis provided, the comma-separated names are parsed and added directly todeprecatedElements[](withelementReplacementfor Typography/Link special color handling), before the import scanning phase runs. This means both mechanisms can work together — imports are still scanned normally, and--jsxadds additional targets.Only names matching the known
componentslist are accepted to avoid accidental transforms on unrelated elements.