[docs] Fix Popover JSdoc#48310
Merged
mj12albert merged 2 commits intoApr 16, 2026
Merged
Conversation
the popover docs said "scroll and click away are blocked" which was misleading since click away isn't blocked the same way scroll is. updated the line to say scrolling is blocked and click away is built-in, which is more accurate and matches what the maintainer suggested in teh issue thread. Signed-off-by: nitzan-treg <nitzan.tregerman@gmail.com>
Bundle size
Deploy previewCheck out the code infra dashboard for more information about this PR. |
mj12albert
changed the title
mj12albert
approved these changes
Apr 16, 2026
Member
mj12albert
left a comment
mj12albert
left a comment
There was a problem hiding this comment.
Thanks for the PR ~ I tweaked the wording a bit more
mj12albert
force-pushed
the
fix/39973-docsmaterial-ui-popover-docs-seem-somewh
branch
from
b6ef186 to
aa798ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey, saw #39973 and took a look
the popover docs said "scroll and click away are blocked" which was misleading since click away isn't blocked the same way scroll is. updated the line to say scrolling is blocked and click away is built-in, which is more accurate and matches what the maintainer suggested in teh issue thread.
fixes #39973