[docs] Improve accessibility for select examples#48250
Merged
Merged
Conversation
silviuaavram
added
docs
Netlify deploy previewBundle size report
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Material UI Select documentation demos to improve accessibility and clarify variant usage, especially around labels and helper text.
Changes:
- Add an outlined Select example to the variants demo and adjust labeling props accordingly.
- Link helper text to Select components in the labels demo via
aria-describedby+ helper textid. - Reorganize and expand docs guidance around variants and labeling/helper text.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/data/material/components/selects/SelectVariants.tsx | Adds outlined variant example; removes unnecessary label prop from standard variant. |
| docs/data/material/components/selects/SelectVariants.js | Same as TS demo for JS version. |
| docs/data/material/components/selects/SelectLabels.tsx | Adds aria-describedby and stable helper text IDs; refines labeling text. |
| docs/data/material/components/selects/SelectLabels.js | Same as TS demo for JS version. |
| docs/data/material/components/selects/selects.md | Renames variants section, moves outlined-label warning, and adds labeling/helper-text guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
silviuaavram
force-pushed
the
docs/select-improvements
branch
from
fd66f3f to
593c3f3
Compare
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have followed (at least) the PR section of the contributing guide.
link helper text elements with Select components.
show an outline variant for the Select
improve the label prop related text and move it to the right section