[code-infra] Use vale rules from code-infra package by brijeshb42 · Pull Request #48173 · mui/material-ui

brijeshb42 · 2026-04-01T19:34:39Z

Implements changes in mui/mui-public#1276

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2026-04-01T19:35:29Z

Netlify deploy preview

https://deploy-preview-48173--material-ui.netlify.app/

Bundle size report

Bundle	Parsed size	Gzip size
@mui/material	0B^(0.00%)	0B^(0.00%)
@mui/lab	0B^(0.00%)	0B^(0.00%)
@mui/system	0B^(0.00%)	0B^(0.00%)
@mui/utils	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 2bc3d61

brijeshb42 · 2026-04-02T06:04:17Z

 ```

-### Testing
+### Testing JSDOM


This was just to check the error reporting. But since the workflow change is in this PR, it only gets read-only token. So vale cant add annotations to the PR.
Once this PR gets merged, annotation will get added inline.

brijeshb42 · 2026-04-02T06:06:47Z

+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        id: vale-inputs
+        run: |
+          echo "files=$(git ls-files '*.md' '*.mdx' | paste -sd ',' -)" >> $GITHUB_OUTPUT


If we don't do this, vale traverses the whole directory tree, including node_modules and breaks when it encounters symlinks. Even its glob flag doesnt work.
We could also update this to only consider the changed md files in the PR and not all md files.

run: | if [ "${{ github.event_name }}" = "pull_request" ]; then FILES=$(git diff --name-only --diff-filter=ACMR ${{ github.event.pull_request.base.sha }}..HEAD -- '*.md' '*.mdx' | paste -sd ',' -) else FILES=$(git ls-files '*.md' '*.mdx' | paste -sd ',' -) fi echo "files=$FILES" >> $GITHUB_OUTPUT echo "version=$(node -p 'require("./package.json").mui.valeVersion')" >> $GITHUB_OUTPUT

brijeshb42 · 2026-04-02T06:10:39Z

  "version": "9.0.0-beta.0",
  "private": true,
+  "mui": {
+    "valeVersion": "3.12.0"


this will not automatically update through renovate. So we can either keep it as-is (update manually or through custom renovate manager) or add @vvago/vale as a devDepedency back insted of the current pnpm dlx based usage.

brijeshb42 · 2026-04-02T06:14:12Z

+          # Required, set by GitHub actions automatically:
+          # https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
+          token: ${{secrets.GITHUB_TOKEN}}
+          version: ${{ steps.vale-inputs.outputs.version }}


without flags, it logs warnings as well. So we can pass flags to filter based just on errors similar to what we do in pnpm valelint - vale --filter='.Level==\"error\"'

Copilot

Pull request overview

This PR migrates Vale configuration/rules to consume the shared rules shipped from @mui/internal-code-infra, removing the in-repo docs/mui-vale rules bundle and wiring Vale into the main CI workflow.

Changes:

Point Vale’s .vale.ini to use rules from @mui/internal-code-infra instead of docs/mui-vale.zip.
Remove the docs/mui-vale rule sources and the dedicated vale-action.yml workflow.
Add Vale execution to .github/workflows/ci.yml and centralize the Vale CLI version in package.json.

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`package.json`	Adds a central `mui.valeVersion` and updates `valelint`; switches `@mui/internal-code-infra` to a `pkg.pr.new` URL.
`pnpm-lock.yaml`	Updates lockfile entries to match the `@mui/internal-code-infra` source change.
`.vale.ini`	Switches Vale package source from `docs/mui-vale.zip` to `@mui/internal-code-infra`.
`.github/workflows/ci.yml`	Runs Vale as part of CI (Ubuntu leg) and adjusts job permissions.
`.github/workflows/vale-action.yml`	Removes the standalone Vale workflow.
`docs/mui-vale/**` (multiple deletions)	Removes the previously vendored MUI Vale rules/styles and related config.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-02T06:18:09Z

+      - name: Collect Vale inputs
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        id: vale-inputs
+        run: |
+          echo "files=$(git ls-files '*.md' '*.mdx' | paste -sd ',' -)" >> $GITHUB_OUTPUT
+          echo "version=$(node -p 'require("./package.json").mui.valeVersion')" >> $GITHUB_OUTPUT
+      - name: Vale
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        uses: vale-cli/vale-action@d89dee975228ae261d22c15adcd03578634d429c # v2.1.1
+        continue-on-error: true # GitHub Action flag needed until https://github.com/errata-ai/vale-action/issues/89 is fixed


The Vale step is added to ci.yml, but this workflow is configured with on.pull_request.paths-ignore: ['docs/**']. As a result, PRs that only touch docs/markdown won’t run this workflow, so Vale won’t run on the changes it’s meant to validate. Consider keeping Vale in a separate workflow that runs on all PRs (or at least on docs/**), or adjusting the CI/CI Check path filters so Vale still executes for docs-only PRs.

Copilot · 2026-04-02T06:18:09Z

    "@mui/internal-babel-plugin-minify-errors": "2.0.8-canary.24",
    "@mui/internal-bundle-size-checker": "1.0.9-canary.70",
-    "@mui/internal-code-infra": "0.0.4-canary.11",
+    "@mui/internal-code-infra": "https://pkg.pr.new/mui/mui-public/@mui/internal-code-infra@d11ec04",


@mui/internal-code-infra is pinned to a pkg.pr.new preview URL. Those preview artifacts are intended for temporary testing and can become unavailable over time, which would break installs and make builds less reproducible. Please switch this back to a published version/range (e.g. the canary you had before) and only use pkg.pr.new overrides locally or in short-lived test branches.

Suggested change

"@mui/internal-code-infra": "https://pkg.pr.new/mui/mui-public/@mui/internal-code-infra@d11ec04",

"@mui/internal-code-infra": "workspace:^",

code-infra-dashboard · 2026-04-29T06:18:36Z

Bundle size

Bundle	Parsed size	Gzip size
@mui/material	0B^(0.00%)	0B^(0.00%)
@mui/lab	0B^(0.00%)	0B^(0.00%)
@mui/private-theming	0B^(0.00%)	0B^(0.00%)
@mui/system	0B^(0.00%)	0B^(0.00%)
@mui/utils	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Deploy preview

https://deploy-preview-48173--material-ui.netlify.app/

Check out the code infra dashboard for more information about this PR.

Janpot

Was there a specific reason to move this from circle to GHA?

brijeshb42 · 2026-04-29T08:43:09Z

Was there a specific reason to move this from circle to GHA?

Both had it actually. Circle has general linting and github has linting with code annotations through the cake action. If we don't need the annotation, we can just keep the circle ci one.

Janpot · 2026-04-29T08:48:38Z

Right, I see. I don't find them particularly useful, but maybe someone on the team?

brijeshb42 · 2026-04-29T08:50:36Z

We can do a team poll to validate if we need it or not. I am assuming it'll help devex team.

oliviertassinari · 2026-04-29T09:01:56Z

Both had it actually. Circle has general linting and github has linting with code annotations

Correct.

I think both are important: It's about the rule that are warning. Rules that are error should break the CI, so easy, only Circle CI, but warnings go silent if they are not shown in the Code diff view as annotations.

The previous URL https://github.com/mui/material-ui/raw/HEAD/docs/mui-vale.zip was removed in mui/material-ui#48173 — vale rules now live in @mui/internal-code-infra. Match material-ui's own .vale.ini.

brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Apr 1, 2026

github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 2, 2026

brijeshb42 force-pushed the vale-refactor branch 2 times, most recently from f840749 to 7028099 Compare April 2, 2026 05:07

github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 2, 2026

brijeshb42 force-pushed the vale-refactor branch 9 times, most recently from b9b8ffa to b011ff5 Compare April 2, 2026 05:59

brijeshb42 mentioned this pull request Apr 2, 2026

[docs-infra] Enforce Vale mui/mui-public#226

Closed

brijeshb42 commented Apr 2, 2026

View reviewed changes

brijeshb42 force-pushed the vale-refactor branch from b011ff5 to c0383e8 Compare April 2, 2026 06:05

brijeshb42 commented Apr 2, 2026

View reviewed changes

brijeshb42 requested review from a team, Copilot and oliviertassinari April 2, 2026 06:11

brijeshb42 marked this pull request as ready for review April 2, 2026 06:11

Copilot started reviewing on behalf of brijeshb42 April 2, 2026 06:12 View session

brijeshb42 commented Apr 2, 2026

View reviewed changes

Copilot AI reviewed Apr 2, 2026

View reviewed changes

brijeshb42 force-pushed the vale-refactor branch 3 times, most recently from 1975681 to 72b7ad0 Compare April 2, 2026 07:06

brijeshb42 force-pushed the vale-refactor branch 3 times, most recently from c85e313 to 5434e8e Compare April 2, 2026 16:35

github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 2, 2026

Janpot reviewed Apr 2, 2026

View reviewed changes

Comment thread package.json Outdated

brijeshb42 force-pushed the vale-refactor branch from 440a1dc to ae58490 Compare April 3, 2026 10:54

github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 3, 2026

brijeshb42 force-pushed the vale-refactor branch from aecd276 to 2bc3d61 Compare April 3, 2026 12:03

github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 6, 2026

brijeshb42 force-pushed the vale-refactor branch from 2bc3d61 to 20fe39f Compare April 29, 2026 06:15

github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 29, 2026

brijeshb42 force-pushed the vale-refactor branch from 075978f to b53f41d Compare April 29, 2026 07:12

Janpot approved these changes Apr 29, 2026

View reviewed changes

brijeshb42 force-pushed the vale-refactor branch from b53f41d to 3dfcb33 Compare April 29, 2026 09:19

brijeshb42 added 2 commits April 29, 2026 14:50

[code-infra] Use vale rules from code-infra package

c1c30b1

Single source of vale-version with caching

ccaf5e0

brijeshb42 force-pushed the vale-refactor branch from 3dfcb33 to ccaf5e0 Compare April 29, 2026 09:20

Dedupe

931e7a1

brijeshb42 enabled auto-merge (squash) April 29, 2026 09:44

brijeshb42 merged commit afc6067 into mui:master Apr 29, 2026
22 checks passed

brijeshb42 deleted the vale-refactor branch April 29, 2026 09:46

This was referenced Apr 29, 2026

[code-infra] Use vale rules from code-infra package mui/base-ui#4706

Merged

[code-infra] Use vale rules from code-infra package mui/mui-x#22256

Merged

	"@mui/internal-code-infra": "https://pkg.pr.new/mui/mui-public/@mui/internal-code-infra@d11ec04",
	"@mui/internal-code-infra": "workspace:^",

Uh oh!

Conversation

brijeshb42 commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Netlify deploy preview

Bundle size report

Uh oh!

brijeshb42 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

brijeshb42 Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brijeshb42 Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brijeshb42 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

code-infra-dashboard Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle size

Deploy preview

Uh oh!

Janpot left a comment

Choose a reason for hiding this comment

Uh oh!

brijeshb42 commented Apr 29, 2026

Uh oh!

Janpot commented Apr 29, 2026

Uh oh!

brijeshb42 commented Apr 29, 2026

Uh oh!

oliviertassinari commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brijeshb42 commented Apr 1, 2026 •

edited

Loading

mui-bot commented Apr 1, 2026 •

edited

Loading

brijeshb42 Apr 2, 2026 •

edited

Loading

brijeshb42 Apr 2, 2026 •

edited

Loading

code-infra-dashboard Bot commented Apr 29, 2026 •

edited

Loading

oliviertassinari commented Apr 29, 2026 •

edited

Loading