Skip to content

[docs-infra] Reapply Cookie Banner with Design Fixes#47744

Merged
dav-is merged 12 commits into
mui:masterfrom
dav-is:davis/reapply-cookie-banner
Feb 23, 2026
Merged

[docs-infra] Reapply Cookie Banner with Design Fixes#47744
dav-is merged 12 commits into
mui:masterfrom
dav-is:davis/reapply-cookie-banner

Conversation

@dav-is
Copy link
Copy Markdown
Member

@dav-is dav-is commented Feb 10, 2026 •
edited by oliviertassinari
Loading

@dav-is dav-is added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). website Pages that are not documentation-related, marketing-focused. labels Feb 10, 2026
@mui-bot
Copy link
Copy Markdown

mui-bot commented Feb 10, 2026 •
edited
Loading

Netlify deploy preview

https://deploy-preview-47744--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 5e68ed3

@dav-is dav-is mentioned this pull request Feb 10, 2026
Merged
@dav-is dav-is marked this pull request as ready for review February 10, 2026 17:55
@Janpot
Copy link
Copy Markdown
Member

Janpot commented Feb 11, 2026

I've updated #47721. I propose we wrap the cookiebanner in this theme provider so that we inherit most of the styling from the branding theme instead of trying to recreate it. This ensures maximum compatibility with the them and prevents drift over time.

@dav-is
Copy link
Copy Markdown
Member Author

dav-is commented Feb 11, 2026

@Janpot ok, I applied your PR and it seems to be working

Janpot
Janpot reviewed Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok from my end.

noraleonte
noraleonte approved these changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see the dark theme and the docs theme are applying correctly now

Leaving just a few nits about the original copy and some small design tweaks. After that, LGTM 👌

Comment thread docs/src/modules/components/AnalyticsProvider.tsx Outdated
Comment thread docs/src/modules/components/AnalyticsProvider.tsx
Comment thread docs/src/modules/components/AnalyticsProvider.tsx Outdated
dav-is and others added 3 commits February 16, 2026 10:42
@dav-is @noraleonte
Apply suggestions from code review
29c430a 
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Signed-off-by: Connor Davis <mail@connordav.is>
@dav-is
Merge branch 'master' into davis/reapply-cookie-banner
199abaa
@dav-is
Prettier
5e68ed3
@dav-is dav-is merged commit a38ad4b into mui:master Feb 23, 2026
19 checks passed
@dav-is dav-is deleted the davis/reapply-cookie-banner branch February 23, 2026 16:57
dav-is added a commit that referenced this pull request Feb 23, 2026
@dav-is @noraleonte
[docs-infra] Reapply Cookie Banner with Design Fixes (#47744)
4f004cb 
Signed-off-by: Connor Davis <mail@connordav.is>
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
@dav-is dav-is mentioned this pull request Feb 23, 2026
Closed
@oliviertassinari
Copy link
Copy Markdown
Member

oliviertassinari commented May 12, 2026 •
edited
Loading

Ok, cool, the design is a lot better than in the first PR that I reverted (#47445) 👍.

I have added notes in mui/mui-public#321 under "TODO on MUI" on what I see that still needs to be worked on to complete the work with this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Janpot Janpot Janpot left review comments

@noraleonte noraleonte noraleonte approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees

No one assigned

Labels

scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. website Pages that are not documentation-related, marketing-focused.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dav-is @mui-bot @Janpot @oliviertassinari @noraleonte