[docs] Replace Checkbox with Icons in Combobox examples#47654
Merged
silviuaavram merged 2 commits intomui:masterfrom Jan 21, 2026
Merged
[docs] Replace Checkbox with Icons in Combobox examples#47654silviuaavram merged 2 commits intomui:masterfrom
silviuaavram merged 2 commits intomui:masterfrom
Conversation
Netlify deploy preview
Bundle size report
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the Material-UI Checkbox component with direct icon rendering in documentation examples for Autocomplete and Select components' multiple selection features. The change simplifies the examples by using checkbox icons directly rather than the full Checkbox component.
Changes:
- Replaced
Checkboximports withCheckBoxOutlineBlankIconandCheckBoxIconimports from@mui/icons-material - Introduced a
SelectedIconhelper component that renders the appropriate icon based on selection state - Applied consistent styling (
marginRight: 8, padding: 9, boxSizing: 'content-box') to maintain visual parity with the original Checkbox component
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MultipleSelectCheckmarks.tsx | Replaced Checkbox with SelectedIcon component using checkbox icons for TypeScript Select example |
| MultipleSelectCheckmarks.js | Replaced Checkbox with SelectedIcon component using checkbox icons for JavaScript Select example |
| CheckboxesTags.tsx | Replaced Checkbox with SelectedIcon component using checkbox icons for TypeScript Autocomplete example |
| CheckboxesTags.js | Replaced Checkbox with SelectedIcon component using checkbox icons for JavaScript Autocomplete example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
silviuaavram
force-pushed
the
docs/combobox-checkbox-a11y
branch
from
1529a7f to
63d13e5
Compare
mj12albert
reviewed
Jan 21, 2026
Member
mj12albert
left a comment
mj12albert
left a comment
There was a problem hiding this comment.
Would be good to also tweak the docs a bit: https://mui.com/material-ui/react-autocomplete/#checkboxes
- Changing the heading from "Checkboxes" to "Checked/Selection indicator" or something to that effect? e.g. https://master--base-ui.netlify.app/react/components/combobox#item-indicator
- Maybe add a sentence like "the following example shows using icons to indicate the selection status of eaach item in the listbox"
Member
Author
|
sure @mj12albert let me get to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42159
Replace
Checkboxwith checkbox icons in the docs examples for theAutocompleteandSelectcomponents' multiple selection with checkbox examples.