Merged
Conversation
Netlify deploy previewhttps://deploy-preview-47252--material-ui.netlify.app/ Bundle size report
|
mj12albert
reviewed
Nov 14, 2025
Signed-off-by: Albert Yu <albert@albertyu.co>
mj12albert
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Use ReactDOMClient.createRoot instead of outdated API
Summary
Removes webpack warnings by replacing an outdated React API check with the standard
ReactDOMClient.createRootAPI.Changes
ReactDOM.unstable_createRoot(doesn't exist inreact-dom)ReactDOMClient.createRootdirectly (standard API in React 18+)ReactDOMimportProblem
Webpack was warning:
The code was checking for
ReactDOM.unstable_createRoot, which doesn't exist in the current version ofreact-dom.Solution
Since we're using React 19, we can use
ReactDOMClient.createRootdirectly, which is the standard API for React 18+.Testing
unstable_createRootare eliminatedThis PR now only focuses on fixing the React DOM client API usage.